Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed move keyword collision and made cloneable #3

Merged
merged 3 commits into from
Oct 13, 2014
Merged

Fixed move keyword collision and made cloneable #3

merged 3 commits into from
Oct 13, 2014

Conversation

tsurai
Copy link
Contributor

@tsurai tsurai commented Oct 13, 2014

The keyword move has been added in version 0.12.0 and collides with the move Event function causing an compile error. This pull request adds the prefix is_ to all boolean Event functions in order to fix this problem.

Additionally both INotify and Event are now deriving Clone to make them usable in cloneable environments.

@hannobraun
Copy link
Owner

Thank you for this pull request!
The changes look good, however, the project won't build with the latest nightly due to rust-lang/rust#17853. Basically, all static declarations should become const.

Would you mind fixing this while you're at it? If you don't have the time, I'll just merge this as is and make the const change later myself.

@tsurai
Copy link
Contributor Author

tsurai commented Oct 13, 2014

Thanks @hannobraun for checking the nightly build. My own rustc is only about two days old and I didn't notice that they had such a big change.
I have pushed a new commit to fix the recent change of the static keyword.

hannobraun added a commit that referenced this pull request Oct 13, 2014
Fixed move keyword collision and made cloneable
@hannobraun hannobraun merged commit c72afec into hannobraun:master Oct 13, 2014
@hannobraun
Copy link
Owner

Awesome, thank you!

Development has certainly gotten a lot calmer since I started with Rust around November/December last year. That makes it all the more surprising when they sneak in a big breaking change like that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants