Using psr/http-message:^2.0 and updating dependencies
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansott |
|
@KentarouTakeda I will review in the evening, thanks! |
hansott
reviewed
Jan 7, 2024
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "scrutinizer/ocular": "~1.1", | ||
| "guzzlehttp/psr7": "^1.3", | ||
| "guzzlehttp/psr7": "^1.3 || ^2.0", |
There was a problem hiding this comment.
I'm fine with dropping support for guzzle ^1.3 and http-message ^1.0, what do you think? :)
Then we don't have to mark the test as skipped?
There was a problem hiding this comment.
Yes, I also think it's no problem.
In that case, psr/http-message:^2.0 requires php:^7.2, so I also removed it from the CI php version. Instead, I added a version newer than 8.0 to CI. You can see results here.
https://packagist.org/packages/hansott/psr7-cookies/php-stats
Right now, the dropped versions seems to be used by nobody :)
hansott
approved these changes
Jan 8, 2024
|
Thank you for merging and publishing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides a dependency update to use
psr/http-message:^2.0. It closes #16.To use it, We also needed to update
guzzlehttp/psr7. Addresses breaking changes included in2.0. Fortunately, only the test code was affected, so the old version ofguzzlehttp/psr7can continue to be used.Also, just to be sure, I changed the CI settings in my repository and confirmed that the tests would pass even with recent PHP versions, including the latest, which this repository does not yet support. It passes in all php versions from 7.0 to 8.3.
https://github.com/KentarouTakeda/hansott-psr7-cookies/actions/runs/7406316316