Add support for FreeBSD #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am I doing something wrong here? |
|
Looks the same on https://app.vagrantup.com/generic/boxes/freebsd14 |
|
I think the sync from gerrithub to github is broken, so it may be behind.
lch@ also has some pending changes, so this issue may have been closed too
early.
…On Sat, Apr 27, 2024 at 9:10 PM rfjakob ***@***.***> wrote:
Looks the same on https://app.vagrantup.com/generic/boxes/freebsd14
***@***.*** ~/go-fuse/fs]$ uname -a
FreeBSD freebsd14.localdomain 14.0-RELEASE FreeBSD 14.0-RELEASE #0 releng/14.0-n265380-f9716eee8ab4: Fri Nov 10 05:57:23 UTC 2023 ***@***.***:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
***@***.*** ~/go-fuse/fs]$ go version
warning: GOPATH set to GOROOT (/home/vagrant/go) has no effect
go version go1.22.2 freebsd/amd64
***@***.*** ~/go-fuse/fs]$ git describe
v2.5.1-8-g90eabd7
***@***.*** ~/go-fuse/fs]$ go build
warning: GOPATH set to GOROOT (/home/vagrant/go) has no effect
# github.com/hanwen/go-fuse/v2/fs
./files.go:44:25: cannot convert (*loopbackFile)(nil) (value of type *loopbackFile) to type FileAllocater: *loopbackFile does not implement FileAllocater (missing method Allocate)
./files.go:211:13: f.utimens undefined (type *loopbackFile has no field or method utimens)
./bridge.go:257:2: undefined: setBlocks
./loopback.go:126:32: undefined: intDev
./loopback.go:344:9: undefined: NewLoopbackDirStream
—
Reply to this email directly, view it on GitHub
<#509 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHWO7HRZMDKSBRAAJB6RDY7PZYRAVCNFSM6AAAAABFS32LNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGE2TINRRGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Han-Wen Nienhuys - ***@***.*** - http://www.xs4all.nl/~hanwen
|
|
Sorry for the inconvenience. There are some commits I proposed on gerrit have not synced to github. And I'm still working on it. |
|
Understood. Adding "GOOS=freebsd go build" to github ci would be nice
(maybe outside of the matrix)
…On Sun, 28 Apr 2024, 01:00 lch, ***@***.***> wrote:
Sorry for the inconvenience. There are some commits I proposed on gerrit
have not synced to github. And I'm still working on it.
—
Reply to this email directly, view it on GitHub
<#509 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACGA72XEXP45RN3F6WZQZTY7QU2RAVCNFSM6AAAAABFS32LNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGIZDOMBWHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to add support for FreeBSD, which is mentioned in issue #85 #120 #415 #432 .
In this PR, I have added the proper functions needed for build on FreeBSD, and I have tested building successfully on FreeBSD 14.0-RELEASE, with following building command (as Darwin)
Some syscalls and constants which are lacking on FreeBSD are replaced to similar ones. And some functions specific on Linux/Darwin are moved to corresponding
_linux.goand_darwin.go.However, there are still some tests which will fail the
go testcommand, like test infuse/nodefswill fail. For exampleTestMemNodeFsWriteandTestMemNodeFsBasic. And I have noticed that in the run of some tests, it will hang for unknown reason radomly, likeTestMemNodeFsWriteinfs/nodefs, which made it hard to debug. Since they are marked as deprecated api, I'm not sure whether they should be fixed.I am committed to persistently investigating the problems, and hoping them get resolved. I would greatly appreciate your comments and suggestions.