-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nil fileEntry #537
fix nil fileEntry #537
Conversation
on Create, after addNewChild fe(fileEntry) is nil value
needs a test that repros the problem. |
accessing a property of an object that does not exist. |
needs a test that demonstrates the crash. |
go test -run ^TestRawBridgeCreateNilFileEntry$ -v Problem area - comment if
Your test should create a file system, mount it, and then trigger the crash. I suspect that creating a file in an FS that doesn't use file handles might do the trick. |
Test change of pool reguest
Changed the test. |
why are you proposing this fix then? |
because I get an error in the latest version |
fix nil pointer dereference |
Is there any chance of correction?
|
I am still waiting for a test that demonstrates a crash in a filesystem without this fix. If you have a FS that doesn't work, it should be straightforward to distill that into a test. |
Addresses #537 Change-Id: I832d93efbf993d63f9163d1ca7bf07b4602bda56
release tagged as v2.6.4 |
on Create, after addNewChild fe(fileEntry) is nil value