Skip to content

Commit

Permalink
chore: correct the comments in KeepAlive.ts [skip ci]
Browse files Browse the repository at this point in the history
- The timing of caching subtree was changed in vuejs#1984
- The attr fallthrough / scopedId issue is actually vuejs#1511 instead of vuejs#1513
  • Loading branch information
haoqunjiang committed May 23, 2024
1 parent bbb5be2 commit f93a534
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/runtime-core/src/components/KeepAlive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,11 @@ const KeepAliveImpl: ComponentOptions = {
rawVNode.ssContent = vnode
}
}
// #1513 it's possible for the returned vnode to be cloned due to attr
// #1511 it's possible for the returned vnode to be cloned due to attr
// fallthrough or scopeId, so the vnode here may not be the final vnode
// that is mounted. Instead of caching it directly, we store the pending
// key and cache `instance.subTree` (the normalized vnode) in
// beforeMount/beforeUpdate hooks.
// mounted/updated hooks.
pendingCacheKey = key

if (cachedVNode) {
Expand Down

0 comments on commit f93a534

Please sign in to comment.