Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on deprecated gulp-util #151

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Drop dependency on deprecated gulp-util #151

merged 2 commits into from
Jan 5, 2018

Conversation

TheDancingCode
Copy link
Contributor

Closes #150.

In passing, I made a test compatible with Windows by replacing hardcoded \n newlines with os.EOL.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 84.158% when pulling 7fc271a on TheDancingCode:issue-150 into 9c84c87 on coderhaoxin:master.

demurgos
demurgos approved these changes Jan 5, 2018
View reviewed changes
Copy link

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Also thanks for solving the issue with EOL.

@coderhaoxin
Could we have this merged and published?

@demurgos demurgos mentioned this pull request Jan 5, 2018
Closed
@haoxins haoxins merged commit 07cc720 into haoxins:master Jan 5, 2018
@haoxins
Copy link
Owner

haoxins commented Jan 5, 2018

v2.0.1 published ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demurgos demurgos demurgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheDancingCode @coveralls @haoxins @demurgos