[WIP] Rows are not regexes --- LaTeX only #795
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problematic pattern in
row_spec()
,column_spec()
and maybe elsewhere:magic_mirror(kable_input)
gsub(row, row_modified, perl=TRUE)
In many cases, this works well to modify the table. But whenever the content of the row includes regex tokens, the results are unpredictable.
For example, in issue #582 , the command produces bad results because the row includes dots, which are interpreted as "any character". I suspect that several of the weird corner case bugs reported on the issue tracker stem from this.
This work-in-progress PR switches
perl=TRUE
tofixed=TRUE
, and makes other attendant changes. Since changing these internals could have unpredictable results, I also add a lot of snapshot tests and also tests to see if Rmarkdown documents can compile to PDF.TODO:
[!h]
visible in some tables inawesome_table_in_pdf.pdf
add_indent()
\\makecell
double escape