Skip to content

Now that linked services are possible: add filter maintenance support #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gjvanderheiden opened this issue Dec 10, 2020 · 3 comments
Closed

Comments

@gjvanderheiden
Copy link
Contributor

Filter Maintenance isn't supported yet. Played around with the Apple HomeKit Accessory Simulator and found out that it only works as a linked service. An Air Purifier can have it as a linked service, also mentioned in the HAP spec from Apple.

Using it as a separate service doesn't work, not in the Home app that is. Eve works better and also supports a Filter Maintenance service as a separate service (e.g. not linked to an Air Purifier service).

Then there is an other peculiar issue with homekit: The Home app doesn't support reset filter. Tried it with the Apple HomeKit Accessory Simulator and with a modified version of HAP-Java. Only Eve supports it. But that is an issue on the Apple Home app.

Anyways, wanted to make an issue to mark I'm working on this and a PR will follow.

@yfre
Copy link
Contributor

yfre commented Dec 10, 2020

@gjvanderheiden thanks for opening it. i also started to implement filter for the same reasons - with linked service it makes sense now
at which stage you are? i have created all filter characteristics but not the service yet, which probably another 2-3 hours with testing.

if you are almost ready i will stop and wait for your PR, otherwise i will finish and commit today/tomorrow my PR.

@gjvanderheiden
Copy link
Contributor Author

I've got it working. I also fixed a little issue on the AirPurifier, it didn't support rotation speed

@gjvanderheiden
Copy link
Contributor Author

pr #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants