Refactoring for optional #101

yfre · 2020-03-16T12:58:47Z

a major refactoring based on discussion in #63 and work done by @ccutrer

PR has a breaking changes and is not compliant to previous version.

merge with upstream

merge to upstream

J-N-K · 2020-03-16T21:55:46Z

I don‘t have enough knowledge about HAP or this code to really review this. But sounds good and I would really appreciate seeing a new release so we can get back to regular releases in OH instead of the forked/cherry-picked version we have now.

yfre · 2020-03-16T22:54:43Z

i have just upgraded OH2.5 homekit to this HAP lib on my local. it was pretty straightforward. i will push it to OH repo once this PR is merged.
in meantime will add more accessories to it.

…th OH

ccutrer · 2020-04-01T13:37:12Z

i have just upgraded OH2.5 homekit to this HAP lib on my local. it was pretty straightforward. i will push it to OH repo once this PR is merged.
in meantime will add more accessories to it.

I'd be interested in seeing the OpenHAB PR, even if it can't be merged until this PR is in.

(And sorry I haven't had any time to look into any HAP stuff. Work has been insane the last month or so. I've been seeing notifications though, so I'm aware work is being done).

yfre · 2020-04-01T18:27:18Z

yes, openHab is a good validation for the Java-HAP API concept, e.g addOptionalCharacteristic methods approach work very well, additional interfaces for optional characteristics not.
in any case, adding support for optional attributes required some major changes in OH addon. Im almost done there - only the most interesting items left, thermostat and valve.
i will inform here once the OH PR is created.

J-N-K · 2020-04-12T13:25:39Z

@ccutrer, @timcharper Can we proceed here? I would like to see these improvements (and the fixes for windowcovering and window/door support) in openHAB 2.5.5 but I would prefer not to compile a own version again.

blafois · 2020-04-14T17:08:49Z

Hello! I discover your PR now ... I have also added support for Window / Door and a PR pending. Is the maintainer dead ?

ccutrer · 2020-04-14T17:15:45Z

@blafois not completely dead :). @J-N-K I'm +1 on this PR so far, I just wanted to see how it worked out on the OpenHAB side before fully approving it. Fortunately/unfortunately for me during this lockdown my work has gotten busier than I've ever been (I work in education technology), plus with lots of kids trying to keep up with their own schoolwork... any spare minute I happen to have gets spent trying to relieve a bit of stress, and not working on home automation stuff.

blafois · 2020-04-14T17:19:46Z

Thanks ! So if my understanding is correct - this PR should bring support for Door & Window and as such I might remove mine (#103) ?

yfre · 2020-04-25T23:07:38Z

@blafois yes, this PR adds support for door and window. as this PR includes a major refactoring it could still make sense to merge your PR in order to add door&window support to the last stable version.

regarding validation of this PR. it took a little bit longer to prepare a patch for openhab addon. not that much due the changes in java-hap but mainly due challenges to map openhab items to optional characteristics using labels. at the end, i decided to use metadata.

@ccutrer please take a look on OH PR here openhab/openhab-addons#7495

feedback is welcome. here or directly there.