Skip to content

port of #68 PR on jmDNS to latest code base #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Dec 8, 2020

porting the old PR with jmDNS enhancements to latest code base and updating jmDNS to latest stable version, which is 3.5.6

Signed-off-by: Eugen Freiter freiter@gmx.de

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre
Copy link
Contributor Author

yfre commented Dec 8, 2020

@ccutrer i have ported your older PR to latest code base. i hope it is ok for you.

@ccutrer
Copy link
Collaborator

ccutrer commented Dec 8, 2020

@J-N-K will this cause compatibility issues with OpenHAB? I know netty was/is an issue, and this is another package that OpenHAB also uses itself.

@gjvanderheiden
Copy link
Contributor

gjvanderheiden commented Dec 10, 2020

OpenHab can always choose to exclude dependencies. Locally updated mdns and it runs with no issues. Same with netty.
HAP-java also uses

org.zeromq curve25519-java 0.1.0

which can be deleted with no issues. (I've updated the other libs crypto deps locally too, maybe that's why. My favourate quote:
-"Works on my machine"
+"But we don't ship your machine, do we?" Don't know the original creator of that quote, sorry).

If you can update the deps with no issues, openhab can use the old stone age stuff if they choose to do so. It will still be compatible.

Really dislike not updating because of other projects. It's very well meant and carefull to OpenHab. But this way nobody moves.

@yfre
Copy link
Contributor Author

yfre commented Dec 10, 2020

just checked and openhab was upgraded to jmdns 3.5.6

openhab/openhab-core#1721

i see this version also in my openhab3 setup

@ccutrer ccutrer merged commit 3429fcd into hap-java:master Dec 11, 2020
@yfre yfre deleted the JmDNS_pr_port branch February 12, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants