Skip to content

Fix: Log accessory names not futures #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix: Log accessory names not futures #151

merged 1 commit into from
Jan 27, 2022

Conversation

MariusVolkhart
Copy link
Contributor

Pull Request Checklist

Please confirm that you've done the following when opening a new pull request:

  • For fixes and other improvements, please reference the GitHub issue that your change addresses.
  • For fixes, optimizations and new features, please add an entry to the CHANGES.md file.
  • Run mvn compile before committing, so that the auto-code formatter will format your changes consistently with the rest of the project.

Fixes #150

@MariusVolkhart
Fix: Log accessory names not futures
125de50 
The previous code logged the CompletableFuture, not the name of the accessory.

Fixes hap-java#150
@yfre yfre mentioned this pull request Jan 27, 2022
Closed
@timcharper timcharper merged commit 39dcf16 into hap-java:master Jan 27, 2022
@timcharper
Copy link
Contributor

Obvious fix. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcharper timcharper timcharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessory names are logged incorrectly
2 participants
@MariusVolkhart @timcharper