Optional characteristics for lightbulbs #70
Conversation
|
@beowulfe I'd really like to get your opinion on this; I'm trying to work towards integrating my openhab2 homekit changes merged in to master; if you think this can make a 1.1.x release, then I'll base my changes on it :) |
|
@beowulfe gentle nudge here! :) I know you're super busy, if there's anything I can do to help get this stuff merged and a release out, let me know. I'm just eager to integrate my openhab contributions before they diverge too far from master. |
|
@ccutrer looks like this breaks backwards compat. Let's hold the merge until we release another 1.1.x version, and then we can bump the base version to 1.2.x and break all the things. |
| /** Unsubscribes from changes in the brightness of the light. */ | ||
| void unsubscribeBrightness(); | ||
| @Deprecated | ||
| public interface DimmableLightbulb extends Lightbulb, Brightness { |
There was a problem hiding this comment.
I've been thinking about it... we should really just do away with all of these interfaces and have of the allowed (but optional) characteristics in the Lightbulb itself.
|
Totes. That was all an attempt to maintain backwards compat (which didn't work out). Breaking that will make it all a lot easier. |
ccutrer
force-pushed
the
optional_characteristics
branch
from
578c8be to
e2b07dd
Compare
|
PR updated with just the lightbulb refactor, removing the extra interfaces. I'll separate fan into a new PR. |
| * Extends {@link Lightbulb} with color settings. This will usually be implemented along with {@link | ||
| * DimmableLightbulb}, but not necessarily so. | ||
| * Extends {@link com.beowulfe.hap.accessories.Lightbulb} with color settings. This will usually be | ||
| * implemented along with {@link DimmableLightbulb}, but not necessarily so. |
There was a problem hiding this comment.
ooh, this java doc needs updated.
ccutrer
changed the title
…ightbulb maintaining compatibility with the now-deprecated DimmableLightbulb and ColorfulLightbulb interfaces
ccutrer
force-pushed
the
optional_characteristics
branch
from
e2b07dd to
ec92d02
Compare
| * | ||
| * @author Andy Lintner | ||
| */ | ||
| public interface ColorfulLightbulb extends Lightbulb { | ||
|
|
||
| public interface Color { |
There was a problem hiding this comment.
I like where this is going. After some thought, I wonder if this interface is probably more trouble than it's worth.
Perhaps we can just axe it and have the respective characteristics take lambda functions as appropriate. For read-only characteristics, it takes only a getter function and a subscription. For write-only, only a setter. Then the respective accessories can just return an Optional of the characteristic, with the lambda functions defined as needed?
WDYT?
No description provided.