Logging #78
Merged
Logging #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylintner
reviewed
Apr 14, 2019
| logger.debug( | ||
| String.format( | ||
| "Sending data [%s]:%n%s", | ||
| ctx.channel().remoteAddress().toString(), msg.toString(StandardCharsets.UTF_8))); |
Collaborator
There was a problem hiding this comment.
This is unnecessarily creating objects even when debug logging is off.
Collaborator
Author
There was a problem hiding this comment.
Good point. Pushed an update.
don't hexdump plaintext messages, and log them at DEBUG level so that you don't have to sift through all of the encrypted stuff to figure out what's going on at the HAP level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please confirm that you've done the following when opening a new pull request: