Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dynamic content #605

Merged
merged 20 commits into from
Feb 15, 2024
Merged

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented Nov 12, 2023

Refined how custom web apps can be hosted and how the standard templates can be changed using simple overwrites (FYI @costateixeira )

jkiddo and others added 16 commits August 30, 2023 22:25
# Conflicts:
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ExtraStaticFilesConfigurer.java
#	src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/IImplementationGuideOperationProvider.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR4OperationProvider.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR5OperationProvider.java
@jkiddo
Copy link
Collaborator Author

jkiddo commented Dec 21, 2023

@costateixeira you probably need to talk to some Smile guys if you want this into the starter project.

@joofio
Copy link

joofio commented Jan 16, 2024

Hi,
such a feature would be super welcomed to several projects!

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jan 16, 2024

@dotasek comments?

@costateixeira
Copy link
Contributor

@dotasek probably you are expecting some testing behind this. I have tested and this works, but you may require some test case - is that true?
@jkiddo is this currently going to set the Flintstones image as the default logo? I would hope not.

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jan 16, 2024

@costateixeira lets cook something different up in the next couple of days then

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jan 17, 2024

@costateixeira I've fixed the defaults now to something more proper. Please let me know what else is on your mind.

# Conflicts:
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/IImplementationGuideOperationProvider.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR4OperationProvider.java
#	src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR5OperationProvider.java
@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 14, 2024

@dotasek & @costateixeira would you guys exchange thoughts on where this needs to head - down the drain or into master?

@costateixeira
Copy link
Contributor

costateixeira commented Feb 14, 2024 via email

@joofio
Copy link

joofio commented Feb 14, 2024

i can help with testing.

@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 14, 2024

Sounds good to me - I would just like to not keep maintaining a separate branch but rather get it merged.

Copy link
Member

@patrick-werner patrick-werner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great. I think the PR needs a better description as not only dynamic web_content support was added, but also operations for IG (un)installation.

@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 15, 2024

looking great. I think the PR needs a better description as not only dynamic web_content support was added, but also operations for IG (un)installation.

IIRC then that has already be introduced. I'd say that this PR maybe did some unintended formatting around it.

@jkiddo jkiddo merged commit 9e21d80 into hapifhir:master Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants