-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dynamic content #605
Conversation
document package install feature
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java # src/main/java/ca/uhn/fhir/jpa/starter/ExtraStaticFilesConfigurer.java # src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/IImplementationGuideOperationProvider.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR4OperationProvider.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR5OperationProvider.java
@costateixeira you probably need to talk to some Smile guys if you want this into the starter project. |
Hi, |
@dotasek comments? |
@costateixeira lets cook something different up in the next couple of days then |
@costateixeira I've fixed the defaults now to something more proper. Please let me know what else is on your mind. |
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/IImplementationGuideOperationProvider.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR4OperationProvider.java # src/main/java/ca/uhn/fhir/jpa/starter/ig/ImplementationGuideR5OperationProvider.java
@dotasek & @costateixeira would you guys exchange thoughts on where this needs to head - down the drain or into master? |
I'd say master.
We already had some discussion on how to test this, right?
…On Wed, Feb 14, 2024 at 11:29 AM Jens Kristian Villadsen < ***@***.***> wrote:
@dotasek <https://github.com/dotasek> & @costateixeira
<https://github.com/costateixeira> would you guys exchange thoughts on
where this needs to head - down the drain or into master?
—
Reply to this email directly, view it on GitHub
<#605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3HUUED2OFKT3AVAPR2J43YTSGXZAVCNFSM6AAAAAA7IB6LHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGQ3TMOBWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
i can help with testing. |
Sounds good to me - I would just like to not keep maintaining a separate branch but rather get it merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great. I think the PR needs a better description as not only dynamic web_content support was added, but also operations for IG (un)installation.
IIRC then that has already be introduced. I'd say that this PR maybe did some unintended formatting around it. |
Refined how custom web apps can be hosted and how the standard templates can be changed using simple overwrites (FYI @costateixeira )