Expose Setting for prefetch thresholds #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeforgreen
approved these changes
Sep 25, 2024
bashir2
reviewed
Sep 26, 2024
|
@bashir2 this look better? |
bashir2
approved these changes
Sep 27, 2024
jkiddo
reviewed
Sep 28, 2024
dotasek
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Looks good to me. Tracing startup shows the settings being set via jpaStorageSettings.setSearchPreFetchThresholds in FhirServerConfigCommon
Can confirm what @tadgh was saying with regard to defaults; if the setting is empty in application.yaml, the default values from HAPI FHIR are used (link below)
jkiddo
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion here: hapifhir/hapi-fhir#6109
@bashir2