-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authorization handling for Bundle resources in the output #5953
Merged
codeforgreen
merged 5 commits into
master
from
mm-20240522-bundle-get-page-fails-403-despite-permissions-granted
May 28, 2024
Merged
Fix authorization handling for Bundle resources in the output #5953
codeforgreen
merged 5 commits into
master
from
mm-20240522-bundle-get-page-fails-403-despite-permissions-granted
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Bundle is standalone, authorization should not be checked for resources included in the Bundle.
Formatting check succeeded! |
TipzCM
approved these changes
May 23, 2024
...ver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/AuthorizationInterceptorJpaR4Test.java
Outdated
Show resolved
Hide resolved
...ver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/AuthorizationInterceptorJpaR4Test.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/AuthorizationInterceptor.java
Show resolved
Hide resolved
…get-page-fails-403-despite-permissions-granted
TipzCM
approved these changes
May 27, 2024
...ver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/AuthorizationInterceptorJpaR4Test.java
Show resolved
Hide resolved
...ver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/AuthorizationInterceptorJpaR4Test.java
Outdated
Show resolved
Hide resolved
…stom operation and it is not a standalone type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5953 +/- ##
============================================
+ Coverage 83.39% 83.45% +0.05%
- Complexity 26927 27105 +178
============================================
Files 1681 1692 +11
Lines 103965 104629 +664
Branches 13189 13252 +63
============================================
+ Hits 86702 87315 +613
- Misses 11613 11648 +35
- Partials 5650 5666 +16 ☔ View full report in Codecov by Sentry. |
jamesagnew
approved these changes
May 28, 2024
codeforgreen
deleted the
mm-20240522-bundle-get-page-fails-403-despite-permissions-granted
branch
May 28, 2024 13:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5952
Related to #5644