Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription fhirpath criteria #5975

Merged
merged 17 commits into from
Jun 21, 2024

Conversation

jkiddo
Copy link
Contributor

@jkiddo jkiddo commented May 29, 2024

This PR adds the logical evaluation of fhirPathCriteria to SubscriptionTopics

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (497b9f2) to head (df8c091).
Report is 107 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5975      +/-   ##
============================================
+ Coverage     83.39%   83.52%   +0.12%     
- Complexity    26927    27334     +407     
============================================
  Files          1681     1701      +20     
  Lines        103965   105797    +1832     
  Branches      13189    13355     +166     
============================================
+ Hits          86702    88365    +1663     
- Misses        11613    11723     +110     
- Partials       5650     5709      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkiddo jkiddo marked this pull request as ready for review May 29, 2024 20:53
@jkiddo jkiddo requested review from fil512 and tadgh as code owners May 29, 2024 20:53
@jkiddo jkiddo requested a review from jamesagnew June 11, 2024 09:24
Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please add a changelog, but I'd say it's good to go!

@jkiddo
Copy link
Contributor Author

jkiddo commented Jun 19, 2024

Changelog now added with 5ed27f0

@tadgh tadgh enabled auto-merge (squash) June 21, 2024 18:27
auto-merge was automatically disabled June 21, 2024 18:39

Head branch was pushed to by a user without write access

@tadgh tadgh merged commit f767058 into hapifhir:master Jun 21, 2024
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants