Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5768 Upgrade to latest simple-java-mail and switch to jakarta.mail #6261

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Thopap
Copy link
Contributor

@Thopap Thopap commented Sep 1, 2024

Upgrading javasimplemail to most recent version which use jakarta.mail api's.
Greenmail was updated as well to provide compatiblity during testing.

Because jakarta.mail api's are also packaged within java simplemail, it need to be excluded by default to avoid duplicated classes on the classpath.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (406db33) to head (6c4b50e).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6261    +/-   ##
==========================================
  Coverage     83.54%   83.54%            
- Complexity    27432    27543   +111     
==========================================
  Files          1707     1715     +8     
  Lines        106185   106659   +474     
  Branches      13397    13429    +32     
==========================================
+ Hits          88710    89108   +398     
- Misses        11750    11799    +49     
- Partials       5725     5752    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thopap
Copy link
Contributor Author

Thopap commented Sep 12, 2024

Any Chance zu get a review for my PR? (@jamesagnew or @tadgh ?)

@tadgh
Copy link
Collaborator

tadgh commented Sep 12, 2024

Looks good, but this will require a version bump as it breaks the API. Since this is passing all tests, I'll take over from here to effect a version bump, and add a changelog. Are you OK with being credited as your github ID, real name, and organization?

You can expect this to be shipped in our official november release (7.6.0)

@Thopap
Copy link
Contributor Author

Thopap commented Sep 13, 2024

@tadgh Thank you for considering this PR and performing the next steps for this. I am fine with mentioning my github ID and real name, but skip the organization.

@tadgh tadgh merged commit 3f6d1eb into hapifhir:master Sep 26, 2024
62 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants