[Bugfix] mdm pointcut missing link update #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Gillberg
requested review from
fil512,
tadgh and
AD1306
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6296 +/- ##
============================================
- Coverage 83.54% 83.53% -0.02%
- Complexity 27432 27628 +196
============================================
Files 1707 1720 +13
Lines 106185 106946 +761
Branches 13397 13453 +56
============================================
+ Hits 88710 89333 +623
- Misses 11750 11835 +85
- Partials 5725 5778 +53 ☔ View full report in Codecov by Sentry. |
adriennesox
approved these changes
Sep 17, 2024
tadgh
approved these changes
Oct 4, 2024
tadgh
approved these changes
Oct 4, 2024
|
LGTM, will merge and add a changelog once it passes all tests. Thanks for the contribution it is very appreciated! |
auto-merge was automatically disabled
October 4, 2024 19:35
Head branch was pushed to by a user without write access
Jake-Gillberg
force-pushed
the
bugfix/mdm-pointcut-missing-link-update
branch
from
24b0797
to
2db8985
Compare
|
Had an issue with the format-check, where the check failed because of a failure to comment on the PR, even though spotless reported |
|
No worries, re-running now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an MDM link is updated to be
NO_MATCH, it is possible that other links will be updated as well.All updated links should be reflected in the link event available to the
MDM_POST_UPDATE_LINKpointcut.Resolves #6297