Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing qualifier search for reference search parameters #6306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing qualifier search for reference search parameters #6306

wants to merge 1 commit into from
+497 −484

Conversation

codeforgreen
Copy link
Collaborator

@codeforgreen codeforgreen commented Sep 24, 2024 •
edited
Loading

Fixes #6305

What was done:

  • the condition to check the parameter name in the query was missing and it was added; that made the search return incorrect results when there was already a reference that was populated (non-missing)
  • two changes were applied to the test class: (1) added a test for this use case testSearchWithMissingReference_resourceTypeWithMultipleReferences (2) Changed the grouping of tests so that majority of tests can run for both indexing missing enabled and disabled scenarios. Separated out those that are specific to one setting or the other.

@codeforgreen
Fix missing qualifier search for reference search parameter. Reuse te…
d672b6c 
…sts and run them for both indexing enabled and disabled.
@github-actions GitHub Actions
Copy link

Formatting check succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesagnew jamesagnew jamesagnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search with missing modifier against a reference parameter does not work in certain conditions
2 participants
@codeforgreen @jamesagnew