Update maven wrapper version #1769
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotasek
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Thanks for bringing this to our attention. I tried this locally and there's some additional enhancements that can be added by executing the wrapper plugin.
Could you run this locally, and update your PR?
mvn -N io.takari:maven:wrapper -Dmaven=3.6.3I'll be happy to merge after that's done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mvnw - the linked version was 8 years old, and I was getting a warning about the maven version it downloaded no longer being compatible.