Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump hoek #35

Merged
merged 1 commit into from
Feb 11, 2023
Merged

chore: bump hoek #35

merged 1 commit into from
Feb 11, 2023

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Jan 21, 2023

Needs hapijs/boom#299 before merging/releasing.

@@ -24,7 +24,7 @@ const internals = {

// Hoek

Hoek.Error
Hoek.AssertError
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weak if we have multiple hoek versions in the dependency tree, but I guess it's no different from before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@@ -24,7 +24,7 @@ const internals = {

// Hoek

Hoek.Error
Hoek.AssertError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@Nargonath Nargonath added the dependency Update module dependency label Jan 25, 2023
@Marsup Marsup added this to the 3.0.1 milestone Feb 11, 2023
@Marsup Marsup merged commit 7cfeb88 into master Feb 11, 2023
@Marsup Marsup deleted the chore/bump-hoek branch February 11, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants