Allow specifying level for request start/complete logging #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roessland
force-pushed
the
feat/allow-override-start-complete-level
branch
from
e23380b
to
8a04196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183 .
I couldn't find a way to do this with any existing
optionsso here's a PR that allows specifying the log level for request start, request complete and request error events.It can be useful to log the request start/complete messages on a lower level, such as
debug. For example, if there is too much traffic to log every single request, and you wish to log ondebuglevel by default, and later in the pipeline decide to drop or keep those log entries.