update ignorePaths logic #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Feb 8, 2019
test.js
Outdated
| @@ -1001,7 +1002,8 @@ experiment('ignore request logs for paths in ignorePaths', () => { | |||
| resolver = resolve | |||
| }) | |||
| const stream = sink((data) => { | |||
| expect(data.req.url).to.not.equal('/ignored') | |||
| const url = new URL(data.req.url) | |||
| expect(url.pathname).to.equal('/') | |||
There was a problem hiding this comment.
I'm wondering why these tests where passing before. Did you get a clue on why?
There was a problem hiding this comment.
data.req.url was undefined, so it passed because it wasn't /ignored.
There was a problem hiding this comment.
Sorry, not undefined, but it was a full URL (http://colins-macbook-pro.local:0/)
|
@cjihrig tests are failing with Hapi@17: https://travis-ci.org/pinojs/hapi-pino/jobs/490787436. |
According to the hapi 18 release notes, request.url.path has gone away in favor of request.path or request.url.pathname. The same release notes also state that request.url.pathname has not changed. Refs: hapijs/hapi#3871
|
@mcollina pushed up something that should fix it |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the hapi 18 release notes,
request.url.pathhas gone away in favor ofrequest.pathorrequest.url.pathname. The same release notes also state thatrequest.url.pathnamehas not changed.Refs: hapijs/hapi#3871