Improve browser support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to pino v5.12.3 which includes fix from pinojs/pino#612 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
1 similar comment
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Apr 26, 2019
This is a temporary fix until js-ipfs switches to a release of hapi-pino that includes hapijs/hapi-pino#76
|
This should not be needed, updating your dependencies would get this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps pino to v5.12.3 to include browser fix from pinojs/pino#612
Why?
It enables
hapi-pinoto be used within Hapi embedded in WebExtension context: ipfs/ipfs-companion#664 ipfs/ipfs-companion#716