Abort response on stream error mid-response

[hueniverse]

If a 200 response using a stream fails, the client will get an incomplete 200 response instead of a complete 500.

[hueniverse]

Not worth the complexity.

[feugy]

Hi !

Just in case, is this behaviour still complex to fix ?
I'm proxying data from S3 using streams, and would like to return a 404 when downloaded file doesn't exists, or a 500 when download failed for any other reason.

It's easy to mitigate the first, by testing the file existence, but I don't see any possibility to do the second.

Thanks in advance for your time !

[hueniverse]

No easy solution. Once you start piping the stream, you already set the status code.

[Marsup]

Facing the same issue, it seems adding request.raw.res.destroy() after

hapi/lib/transmit.js

Line 268 in 513cea8

request.emit('disconnect');

is sufficient to at least let the browser know something went wrong (aka forcefully interrupting the connection). See any downside to this ?

[kanongil]

Forcefully closing the socket is the only, and best, option there is. This is probably something that hapi should do already. Otherwise, the client will just wait for data that is never coming. Worse, if it is a http keep-alive request, it can have pending pipelined requests that will never be fulfilled.

The client should be able to deduce that it received a partial response, and handle it however it sees fit.