Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API.md to remove deprecated date.format syntax from an example #1064

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

WesTyler
Copy link
Contributor

Removes v10.x deprecated Joi.date().format() syntax from API.md example, per #1063.

@AdriVanHoudt
Copy link
Contributor

I don't think the example is still as clear as before with this change

@AdriVanHoudt AdriVanHoudt added the documentation Non-code related changes label Dec 13, 2016
@WesTyler
Copy link
Contributor Author

@AdriVanHoudt you're right. That's what happens when I make assumptions. My bad.
I modified the example to utilize date().timestamp() and show the difference in behavior with and without .raw().

@Marsup Marsup self-assigned this Dec 13, 2016
@Marsup Marsup merged commit 9e111c9 into hapijs:master Dec 13, 2016
@AdriVanHoudt
Copy link
Contributor

@WesTyler this makes it even better than before 🎉

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Non-code related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants