add URL and URLSearchParams to global variables #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably be added like in L92-115. |
|
Done. |
|
I do not know why that test is failing (see https://travis-ci.org/hapijs/lab/jobs/339389589), I think that test is flaky. |
|
Can't get a flake locally but apparently travis can indeed. |
|
Thanks for the help @mcollina |
|
No worries, I'm trying to get CITGM greener, and this was on the list. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those will be globals in Node 10 (and current are in node master).
I'm sending this PR early because shot is currently failing on CITGM.
Ref hapijs/shot#91.