Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to hapi 18 #175

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Update to hapi 18 #175

merged 1 commit into from
Jan 21, 2019

Conversation

WesTyler
Copy link
Contributor

Looking at the v18 release notes I didn't see anything that needed to be updated here, and tests are all passing :)

wswoodruff
wswoodruff approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@wswoodruff wswoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! E-Z upgrade

@wswoodruff
Copy link
Contributor

Thanks for the effort here @WesTyler

@wswoodruff wswoodruff merged commit bc5d52d into hapijs:master Jan 21, 2019
@devinivy
Copy link
Member

I just remembered—hapi's requirements plugin config expresses a peer dependency on hapi that also needs updating.

@devinivy
Copy link
Member

I take it back—the version range only sets a lower bound on the hapi version :)

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wswoodruff wswoodruff wswoodruff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WesTyler @wswoodruff @devinivy