Handle stream payload errors before socket connection #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#223 introduced a small window between the creation of the request and the socket connection wherein
error
events on the payload would have no attached handler and could cause uncaught exceptions.This PR includes a regression test as well as the fix:
options.payload
whose piping has been deferredreq
itself and allow this to clean itself upOpen questions:
socket
listener inonStreamError
?req.emit('error', err)
as the mechanism to propagate the error?