More aggresively hide the ObjectiveTrackerFrame #79
Conversation
There was a problem hiding this comment.
Oh wow, that's actually very smart. Does the frame stay parented indefinitely?
There's a few other places where we hide the frame apart from the WarpDeplete:Show, those need to be removed too if this just universally works. HideBlizzardObjectiveTracker should pretty much only be called in WarpDeplete:Show, I think.
|
CC @XCreative @Erieeroot and @rootkit1337tv, since you guys were a part of the original issue/fix. If anyone could get a run or 2 done using this branch and check if everything is working correctly, I'd be very thankful 🙏 |
|
parents persist until /reload or changed through SetParent (which blizzard almost never does for any frame), so yeah, this approach is perfect when trying to hide blizzard frames 🙂 I haven't really dug into the rest of the addon's code, so it might be simpler to make required adjustments yourself, but I can try clean things up a bit more when I get time later 🙂 |
|
Right, I'll do the adjustments then and you can make sure they work correctly. Give me a sec |
|
Alright, done. Let's get this tested and merged! |
|
I'll play a few keys with it tonight (EU) and let you know 👍 |
|
Same here I will do some keys tonight and let you know. I grabbed that CPU addon you mentioned so I will try to monitor that as well, but so far I have not had a single issue in keys so fingers crossed. |
For this branch, you won't have to monitor the CPU at all, since this is an actual fix and not just a hack. |
|
worked fine for my keys 👍 |
|
Sounds good, I'll merge this tomorrow then. |
|
For what it's worth, tried all the usual suspects and so far working fine here too :) |
now blizzard can :Show/:Hide the objective tracker as much as they like. once it's hidden, it stays hidden until you decide it should no longer be hidden