Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update styledoutput ids when merge is completed in branch service #217

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

MikeVanMourik
Copy link
Contributor

Describe your changes

check and update styledoutput ids inside styled outputs when we encounter a updated id in a merge

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

tested on wiser demo with local hookup

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

nein

Link to Asana ticket

jira

Copy link
Contributor

@HansHappyHorizon HansHappyHorizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine, but I found some pieces that are against our style guide. Please update these.

@HansHappyHorizon HansHappyHorizon merged commit d5bce77 into develop Aug 14, 2024
@HansHappyHorizon HansHappyHorizon deleted the feature/update-styledoutput-after-merge branch August 14, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants