Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle if the Wiser refresh token is invalid #231

Merged

Conversation

MarkVanDijkHG
Copy link
Contributor

Describe your changes

When the refresh token for the Wiser API was invalid/expired it was unable to recover from this. Now it will execute a normal login.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

Tested by ensuring an invalid token is sent to the Wiser API to see if it falls back on the normal login.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Link to Asana ticket

https://app.asana.com/0/1205090868730163/1207886429176436

When the refresh token for the Wiser API was invalid/expired it was unable to recover from this. Now it will execute a normal login.
@HansHappyHorizon HansHappyHorizon merged commit 8e15b4b into develop Sep 4, 2024
@HansHappyHorizon HansHappyHorizon deleted the feature/handle-invalid-wiser-refresh-token branch September 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants