Skip to content

Commit

Permalink
Freewheel - Converted the ComponentId property to be 'prebid' in requ…
Browse files Browse the repository at this point in the history
…est (prebid#5320)

* freewheel-ssp fix issue on playerSize of bidRequest

* freewheel add dealId property in bidResponse

* freewheel convert ComponentID to 'prebid' in request

* freewheel add new parameter 'componentSubId' in request
  • Loading branch information
xwang202 authored and iggyfisk committed Jun 22, 2020
1 parent 927ce3e commit 3ab1397
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
3 changes: 2 additions & 1 deletion modules/freewheel-sspBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@ export const spec = {
reqType: 'AdsSetup',
protocolVersion: '2.0',
zoneId: zone,
componentId: getComponentId(currentBidRequest.params.format),
componentId: 'prebid',
componentSubId: getComponentId(currentBidRequest.params.format),
timestamp: timeInMillis,
pKey: keyCode
};
Expand Down
18 changes: 12 additions & 6 deletions test/spec/modules/freewheel-sspBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
});

Expand All @@ -126,7 +127,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
expect(payload._fw_us_privacy).to.exist.and.to.be.a('string');
expect(payload._fw_us_privacy).to.equal(uspConsentString);
Expand All @@ -145,7 +147,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
expect(payload._fw_gdpr_consent).to.exist.and.to.be.a('string');
expect(payload._fw_gdpr_consent).to.equal(gdprConsentString);
Expand Down Expand Up @@ -178,7 +181,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
});

Expand All @@ -197,7 +201,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
expect(payload._fw_us_privacy).to.exist.and.to.be.a('string');
expect(payload._fw_us_privacy).to.equal(uspConsentString);
Expand All @@ -216,7 +221,8 @@ describe('freewheelSSP BidAdapter Test', () => {
expect(payload.reqType).to.equal('AdsSetup');
expect(payload.protocolVersion).to.equal('2.0');
expect(payload.zoneId).to.equal('277225');
expect(payload.componentId).to.equal('mustang');
expect(payload.componentId).to.equal('prebid');
expect(payload.componentSubId).to.equal('mustang');
expect(payload.playerSize).to.equal('300x600');
expect(payload._fw_gdpr_consent).to.exist.and.to.be.a('string');
expect(payload._fw_gdpr_consent).to.equal(gdprConsentString);
Expand Down

0 comments on commit 3ab1397

Please sign in to comment.