GumGum: adds new param (prebid#5297)

* adds in new videoPubID param * adds test
happypancake · Jun 22, 2020 · 6ff668e · 6ff668e
1 parent e43a1b3
commit 6ff668e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js
@@ -149,7 +149,7 @@ function isBidRequestValid (bid) {
     case !!(params.ICV): break;
     case !!(params.video): break;
     case !!(params.inVideo): break;
-
+    case !!(params.videoPubID): break;
     default:
       utils.logWarn(`[GumGum] No product selected for the placement ${adUnitCode}, please check your implementation.`);
       return false;
@@ -244,6 +244,11 @@ function buildRequests (validBidRequests, bidderRequest) {
       data.ni = parseInt(params.ICV, 10);
       data.pi = 5;
     }
+    if (params.videoPubID) {
+      data = Object.assign(data, _getVidParams(mediaTypes.video));
+      data.pubId = params.videoPubID;
+      data.pi = 7;
+    }
     if (params.video) {
       data = Object.assign(data, _getVidParams(mediaTypes.video));
       data.t = params.video;

diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js
@@ -144,6 +144,27 @@ describe('gumgumAdapter', function () {
       expect(bidRequest.data.pubId).to.equal(request.params.inScreenPubID);
       expect(bidRequest.data).to.not.include.any.keys('t');
     });
+    it('should send pubId if videoPubID param is specified', function () {
+      const mediaTypes = {
+        video: {
+          playerSize: [640, 480],
+          context: 'instream',
+          minduration: 1,
+          maxduration: 2,
+          linearity: 1,
+          startdelay: 1,
+          placement: 123456,
+          protocols: [1, 2]
+        }
+      };
+      const request = Object.assign({}, bidRequests[0]);
+      request.mediaTypes = mediaTypes
+      request.params = { 'videoPubID': 123 };
+      const bidRequest = spec.buildRequests([request])[0];
+      expect(bidRequest.data).to.include.any.keys('pubId');
+      expect(bidRequest.data.pubId).to.equal(request.params.videoPubID);
+      expect(bidRequest.data).to.not.include.any.keys('t');
+    });
     it('should set a ni parameter in bid request if ICV request param is found', function () {
       const request = Object.assign({}, bidRequests[0]);
       delete request.params;