Skip to content

BUG/MINOR: ssl: Add support for skip_reload parameter #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fjaeckel
Copy link
Contributor

This parameter is used to skip the reload after the certificate is updated.

Relates to #365 and haproxytech/client-native#116

@mjuraga
Copy link
Collaborator

mjuraga commented Mar 17, 2025

Can you change the commit message to something like: BUG/MINOR: ssl: Add support for skip_reload parameter to conform to our contribution guide. Also add a go.mod reference to your commit in the client-native: haproxytech/client-native@4fd44b5

@fjaeckel fjaeckel force-pushed the create-ssl-certificate-skip-reload branch from f2f0417 to f159649 Compare March 17, 2025 13:39
@fjaeckel
Copy link
Contributor Author

@mjuraga should be updated as requested

@fjaeckel fjaeckel force-pushed the create-ssl-certificate-skip-reload branch 3 times, most recently from 3c19587 to f356bba Compare March 17, 2025 14:01
@fjaeckel fjaeckel changed the title MINOR: Add support for skip_reload parameter to StorageCreateStorageSSLCertificateHandlerImpl BUG/MINOR: ssl: Add support for skip_reload parameter Mar 17, 2025
This parameter is used to skip the reload after the certificate is created.
We also update client-native/v6 to the latest ref.

Relates to haproxytech#365 and haproxytech/client-native#116
@fjaeckel fjaeckel force-pushed the create-ssl-certificate-skip-reload branch from f356bba to 8f1020d Compare March 17, 2025 14:07
@mjuraga mjuraga merged commit c7eacf1 into haproxytech:master Mar 18, 2025
6 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants