Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Access-Control-Allow-Origin is * do not send Vary #12

Closed
NickMRamirez opened this issue Jun 13, 2020 · 0 comments
Closed

If Access-Control-Allow-Origin is * do not send Vary #12

NickMRamirez opened this issue Jun 13, 2020 · 0 comments

Comments

@NickMRamirez
Copy link
Collaborator

The Fetch specification states in the section on CORS protocol and HTTP caches:

If Access-Control-Allow-Origin is set to * or a static origin for a particular resource, then configure the server to always send Access-Control-Allow-Origin in responses for the resource — for non-CORS requests as well as CORS requests — and do not use Vary.

So, the library should not send Vary: origin when Access-Control-Allow-Origin: *
NickMRamirez added a commit that referenced this issue Jun 13, 2020
@NickMRamirez
Merge pull request #13 from haproxytech/branch_issue12
7e643f3 
Fixed #12
NickMRamirez added a commit that referenced this issue Dec 12, 2020
@NickMRamirez
Issue #12 (Do not send Vary if Allowed-origin is *) had been reverted…
0a72144 
… accidentally. This puts it back in place and also adds it for preflight requests.
NickMRamirez added a commit that referenced this issue Dec 12, 2020
@NickMRamirez
Issue #12 (Do not send Vary if Allowed-origin is *) had been reverted…
958f4d4 
… accidentally. This puts it back in place and also adds it for preflight requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickMRamirez