-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable ASAN for all builds #4
Conversation
let's enable ASAN unconditionally
v2 uses outdated nodejs
It may be a good idea for the normal testcases. However, I'm wondering if there is any impact on performance for the measurement tests ? |
no visible impact. even some other qns images are built using asan enabled by default |
let me check perf testcases. brb soon |
I've compared time taken for goodput,crosstraffic tests with and without ASAN, no difference. I suggest to merge. |
@chipitsine I have tried to use interop runner locally with newly ASAN built, but the test fails with a log full of lines |
as a wild guess, can it be some kernel feature ? do you have ubuntu 24 as docker host to try ? |
something like that ? |
I'm running on Archlinux, kernel 6.11.5. Yes the issue sounds similar. |
I've mentioned ubuntu 24, because we use them in GitHub Actions. But generally it won't work, because those image are tuned on sysctl side |
No description provided.