Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ASAN for all builds #4

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

chipitsine
Copy link
Contributor

No description provided.

let's enable ASAN unconditionally
@a-denoyelle
Copy link
Contributor

It may be a good idea for the normal testcases. However, I'm wondering if there is any impact on performance for the measurement tests ?

@chipitsine
Copy link
Contributor Author

no visible impact. even some other qns images are built using asan enabled by default

@chipitsine
Copy link
Contributor Author

chipitsine commented Nov 6, 2024

let me check perf testcases. brb soon

@chipitsine chipitsine marked this pull request as draft November 6, 2024 08:28
@chipitsine chipitsine marked this pull request as ready for review November 7, 2024 23:13
@chipitsine
Copy link
Contributor Author

I've compared time taken for goodput,crosstraffic tests with and without ASAN, no difference.

I suggest to merge.

@a-denoyelle a-denoyelle merged commit 08a46c4 into haproxytech:master Nov 8, 2024
@a-denoyelle
Copy link
Contributor

a-denoyelle commented Nov 18, 2024

@chipitsine I have tried to use interop runner locally with newly ASAN built, but the test fails with a log full of lines AddressSanitizer:DEADLYSIGNAL. Did you know by any chance what could be the issue ?

@chipitsine
Copy link
Contributor Author

as a wild guess, can it be some kernel feature ?

do you have ubuntu 24 as docker host to try ?
I recall running on Fedora 40, 41 - no issues.

@chipitsine
Copy link
Contributor Author

something like that ?

actions/runner-images#9491

@a-denoyelle
Copy link
Contributor

I'm running on Archlinux, kernel 6.11.5. Yes the issue sounds similar.

@chipitsine
Copy link
Contributor Author

I've mentioned ubuntu 24, because we use them in GitHub Actions. But generally it won't work, because those image are tuned on sysctl side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants