Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD issue for .Capabilities.APIVersions.Has "networking.k8s.io/v1/IngressClass" #211

Closed
Roxyrob opened this issue Nov 7, 2023 · 1 comment

Comments

@Roxyrob
Copy link

Roxyrob commented Nov 7, 2023

Also with latest version of ArgoCD helm chart miss creation of haproxy IngressClass. It seems that ArgoCD doesn't return complete .Capabilities.APIVersions with kind so inside haproxy template for IngressClass .Capabilities.APIVersions.Has will never be true since for ArgoCD helm template command ".Capabilities.APIVersions" will contains "networking.k8s.io/v1" or "networking.k8s.io/v1beta1" without kind part ("/IngressClass"):

---
{{- if or (.Capabilities.APIVersions.Has "networking.k8s.io/v1/IngressClass") (.Capabilities.APIVersions.Has "networking.k8s.io/v1beta1/IngressClass") }}
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/IngressClass" }}
apiVersion: networking.k8s.io/v1
{{- else }}
apiVersion: networking.k8s.io/v1beta1
{{- end }}
kind: IngressClass
...

argoproj/argo-cd#6351

Can you provide a solution/workaround to allow correct helm chart installation with ArgoCD ?

dkorunic added a commit that referenced this issue Nov 7, 2023
Changes in kubernetes-ingress:
- Fixes for .Capabilities.APIVersions issues (issues #202 and #211)
- semverCompare fixes for appProtocol

Signed-off-by: Dinko Korunic <dkorunic@haproxy.com>
@dkorunic dkorunic closed this as completed Nov 7, 2023
@Roxyrob
Copy link
Author

Roxyrob commented Nov 7, 2023

@dkorunic this solved the issue !
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants