feat(governance): use tolgee for translation #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegshilov
changed the title
olegshilov
requested changes
Nov 5, 2024
apps/shell/src/i18n/en.json
Outdated
| @@ -42,7 +42,9 @@ | |||
| "undelegate": "Undelegate", | |||
| "redelegate": "Redelegate" | |||
| }, | |||
| "governance": {}, | |||
| "governance": { | |||
| "your-balance": "Your balance: {{localedBalance}} {{localedSymbolUpperCase}}" | |||
There was a problem hiding this comment.
at first change please this
Suggested change
| "your-balance": "Your balance: {{localedBalance}} {{localedSymbolUpperCase}}" | |
| "your-balance": "Your balance: {{balance}} {{symbol}}" |
at second where is the rest of strings?
Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
olegshilov
force-pushed
the
feat/web-668-use-and-extract-tolgee-keys-governance
branch
from
60bbe72 to
9847790
Compare
olegshilov
approved these changes
Nov 5, 2024
Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
olegshilov
approved these changes
Nov 5, 2024
olegshilov
deleted the
feat/web-668-use-and-extract-tolgee-keys-governance
branch
olegshilov
pushed a commit
that referenced
this pull request
Nov 5, 2024
* feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * fix(governance): simplify your-balance params Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(governance): extract tolgee keys Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * chore: fix build Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> --------- Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
olegshilov
pushed a commit
that referenced
this pull request
Nov 6, 2024
* feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * fix(governance): simplify your-balance params Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(governance): extract tolgee keys Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * chore: fix build Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> --------- Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
olegshilov
pushed a commit
that referenced
this pull request
Nov 6, 2024
* feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * fix(governance): simplify your-balance params Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(governance): extract tolgee keys Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * chore: fix build Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> --------- Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
olegshilov
pushed a commit
that referenced
this pull request
Nov 6, 2024
* feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(tolgee-keys): governance Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * fix(governance): simplify your-balance params Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * feat(governance): extract tolgee keys Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> * chore: fix build Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com> --------- Signed-off-by: viktoriabakun <viktoriabakun00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.