Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HW-761): log all navigation params for Posthog #2115

Merged

Conversation

devkudasov
Copy link
Contributor

Fixes #

Proposed Changes

  • Create SecureValue which hide params from logging
  • Hide privateKey
  • Hide currentPin
  • Hide WalletInitialData

Checklist

@devkudasov devkudasov requested review from ivkhaqq and a team as code owners October 2, 2024 18:41
@devkudasov devkudasov added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit c9b93f6 Oct 7, 2024
4 checks passed
@devkudasov devkudasov deleted the issue/HW-761/log-all-navigation-params-for-all-screens branch October 7, 2024 10:18
devkudasov added a commit that referenced this pull request Oct 7, 2024
* feat(HW-761): Hide privateKey for posthog

* feat(HW-761): Hide currentPin from posthog

* feat(HW-761): Hide WalletInitialData mnemonic and privateKey from posthog

* feat(HW-761): Convert SecureValue method to getter

* up version

* feat(HW-761): FIx hide value string representation
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
* fix(HW-773): Remove banner check for permanent notifications banner

* fix: native swap (#2120)

* fix(HW-759): swap screen issues

* fix(HW-763): added swap finish screen

* feat: added swap tokens sorting

---------

Co-authored-by: iGroza <xneonxneon1@gmail.com>

* fix(HW-762): Reset pin fix (#2116)

* fix(HW-762): Reset pin fix

* up app version

* chore: index.js sugar (#2118)

* chore: Upgrade sentry packages (#2119)

* chore: Upgrade sentry packages

* fix yarn.lock

* pod update

* Update Podfile

* fix: getsentry/sentry-react-native#4095

---------

Co-authored-by: iGroza <xneonxneon1@gmail.com>
Co-authored-by: Kirill Ageychenko <iGroza@users.noreply.github.com>

* feat: reset wallet when keychain broken (#2121)

Co-authored-by: iGroza <xneonxneon1@gmail.com>

* chore(HW-771): update fastlane (#2122)

Co-authored-by: iGroza <xneonxneon1@gmail.com>

---------

Co-authored-by: iGroza <xneonxneon1@gmail.com>
Co-authored-by: Kirill Ageychenko <iGroza@users.noreply.github.com>

* feat(hw-770): implement-open-browser-dynamic-link-for-mobile-wallet (#2117)

Co-authored-by: iGroza <xneonxneon1@gmail.com>

* feat(HW-761): log all navigation params for Posthog (#2115)

* feat(HW-761): Hide privateKey for posthog

* feat(HW-761): Hide currentPin from posthog

* feat(HW-761): Hide WalletInitialData mnemonic and privateKey from posthog

* feat(HW-761): Convert SecureValue method to getter

* up version

* feat(HW-761): FIx hide value string representation

---------

Co-authored-by: Kirill Ageychenko <iGroza@users.noreply.github.com>
Co-authored-by: iGroza <xneonxneon1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants