Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: if $config.json missing, load $config.yaml #28

Merged
merged 7 commits into from
Sep 21, 2017

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented Sep 20, 2017

  • additional test for 'missing json loads yaml'
  • modify get_path_to_config_dir regex to also match windows paths (\ vs / path separator)
  • add tests for get_path_to_config_dir
  • configs w/o .ext or declared type default to flat
  • add test for !filename overloads

@codecov
Copy link

codecov bot commented Sep 20, 2017

Codecov Report

Merging #28 into master will increase coverage by 1.26%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   79.26%   80.53%   +1.26%     
==========================================
  Files           7        7              
  Lines         410      411       +1     
  Branches      115      118       +3     
==========================================
+ Hits          325      331       +6     
+ Misses         85       80       -5
Impacted Files Coverage Δ
configfile.js 70.09% <93.75%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d17634...1ad6450. Read the comment docs.

@msimerson
Copy link
Member Author

Adds another test for json/yaml Overrides:

✔ jsonOverrides - no override for smtpgreeting
Overriding file smtpgreeting with config from /Users/matt/git/haraka-config/test/config/main.json
{ '!smtpgreeting': [ 'this is line one', 'this is line two' ] }
✔ jsonOverrides - with smtpgreeting override

@msimerson msimerson merged commit fced0c4 into master Sep 21, 2017
@msimerson msimerson deleted the missing-json-gets-yaml branch September 21, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant