Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use path.extname instead of regex comparisons #32

Merged
merged 1 commit into from Sep 29, 2017
Merged

use path.extname instead of regex comparisons #32

merged 1 commit into from Sep 29, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2017

fixes #31

Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #32 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   81.27%   81.54%   +0.26%     
==========================================
  Files           8        8              
  Lines         422      428       +6     
  Branches      123      124       +1     
==========================================
+ Hits          343      349       +6     
  Misses         79       79
Impacted Files Coverage Δ
config.js 90.47% <100%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82a402...bdaaa02. Read the comment docs.

@msimerson msimerson merged commit 2f2397c into haraka:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use path.extname instead of regex comparisons
2 participants