add .connect() as is now required, fixes #32 (#34)

.eslintrc.yaml

@@ -2,16 +2,14 @@ env:
   node: true
   es6: true
   mocha: true
+  es2020: true
 
 plugins: [ haraka ]
 
 extends: [ eslint:recommended, plugin:haraka/recommended ]
 
 root: true
 
-parserOptions:
-  ecmaVersion: 2020
-
 globals:
   OK: true
   CONT: true

Changes.md

@@ -1,8 +1,9 @@
 
 
-### 2.0.1 - 2022-05-23
+### 2.0.2 - 2022-05-23
 
 - fix: rename p* methods -> * (required in redis v4)
+- fix: add `await ...connect()` as is now required, fixes #32
 - dep(redis): bump 4.0 -> 4.1
 
 

index.js

@@ -194,12 +194,13 @@ exports.redis_subscribe_pattern = async function (pattern) {
     if (this.redis) return // already subscribed?
 
     this.redis = await redis.createClient(this.redisCfg.pubsub)
+    await this.redis.connect()
 
-    await this.redis.subscribe(pattern);
-    this.logdebug(this, `subscribed to ${pattern}`);
+    await this.redis.pSubscribe(pattern);
+    this.logdebug(this, `pSubscribed to ${pattern}`);
 }
 
-exports.redis_subscribe = async function (connection, event) {
+exports.redis_subscribe = async function (connection) {
 
     if (connection.notes.redis) {
         connection.logdebug(this, `redis already subscribed`);
@@ -211,12 +212,13 @@ exports.redis_subscribe = async function (connection, event) {
     }, 3 * 1000);
 
     connection.notes.redis = await redis.createClient(this.redisCfg.pubsub)
+    await connection.notes.redis.connect()
 
     clearTimeout(timer);
 
     const pattern = this.get_redis_sub_channel(connection)
-    connection.notes.redis.subscribe(pattern, event);
-    connection.logdebug(this, `subscribed to ${pattern}`);
+    connection.notes.redis.pSubscribe(pattern);
+    connection.logdebug(this, `pSubscribed to ${pattern}`);
 }
 
 exports.redis_unsubscribe = async function (connection) {
@@ -229,5 +231,5 @@ exports.redis_unsubscribe = async function (connection) {
     const pattern = this.get_redis_sub_channel(connection)
     await connection.notes.redis.unsubscribe(pattern);
     connection.logdebug(this, `unsubsubscribed from ${pattern}`);
-    connection.notes.redis.disconnect();
+    connection.notes.redis.quit();
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "haraka-plugin-redis",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Redis plugin for Haraka & other plugins to inherit from",
   "main": "index.js",
   "directories": {
@@ -10,10 +10,10 @@
     "redis": "^4.1.0"
   },
   "devDependencies": {
-    "eslint": "^8.12.0",
+    "eslint": "8",
     "eslint-plugin-haraka": "*",
     "haraka-test-fixtures": "*",
-    "mocha": "^9.2.0"
+    "mocha": "9"
   },
   "scripts": {
     "lint": "npx eslint *.js test/*.js",