Fixed missing Buffer to string conversion. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lnedry
commented
Nov 25, 2023
lnedry
commented
- Fixed missing Buffer to string conversion.
- Added test for add_data() when parse_body is true
Fixed missing Buffer to string conversion.
Added test for add_data() when parse_body is true.
msimerson
reviewed
Dec 2, 2023
| @@ -86,7 +86,7 @@ class Transaction { | |||
| line.toString('binary').replace(/\r\n$/, '\n')); | |||
| } | |||
| } | |||
| else if (this.header_pos && this.parse_body) { | |||
| else if (this.parse_body) { | |||
There was a problem hiding this comment.
Are you sure about this change? This change makes the test fixture different than Haraka/transaction.js.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.