Fix double execution of LeftClickCommand #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant WM_LBUTTONUP handling for notification icon clicks, left clicks now handled only by NIN_SELECT. - Fixed LeftClickCommand double execute due to WM_LBUTTONUP was handled.
|
@DarkPro1337 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
LeftClickCommandwas executed twice. The redundant handling of theWM_LBUTTONUPmessage caused the command to be triggered multiple times. By removing theWM_LBUTTONUPmessage handling, theLeftClickCommandis now executed only once when the notification icon is clicked, also ensuring the correct behavior withNoLeftClickDelayenabled.