Enabling support for Amlogic Hardware Watchdog with 60 Sec timeout. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone please take a look at this PR and let me know any edits/modifications needed in this Pull request. |
mdrjr
reviewed
Dec 26, 2018
drivers/watchdog/s905_wdt.c
Outdated
| void hw_watchdog_init(void) | ||
| { | ||
| printf("HW WDT Timeout %d Seconds\n", WDT_HW_TIMEOUT); | ||
| watchdog_init(60 * 1000); |
There was a problem hiding this comment.
use WDT_HW_TIMEOUT here instead of hardcoding it. You already have the #define
There was a problem hiding this comment.
Changed the code, removed hard-coded value and used #define macro.
There was a problem hiding this comment.
@mdrjr I have done the changes. Can you please suggest further improvement?
|
Did this ever get added? |
|
No, I think it has not been added yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created this PR for issue Hardware Watchdog Support for Odroid C2 (Amlogic S905) #51.
Added option in
menuconfigby editingKconfigfile indrivers/watchdogdirectory to enable/disable Amlogic Hardware watchdog.Added a new file
s905_wdt.cunderdrivers/watchdogdirectory for calling low-level SoC watchdog functions.