Prefer IsEmpty over Count/Any

Reported by CA1836
hardkoded · Feb 23, 2023 · 74a9919 · 74a9919
1 parent caf4776
commit 74a9919
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/lib/PuppeteerSharp/CDPSession.cs b/lib/PuppeteerSharp/CDPSession.cs
@@ -111,7 +111,7 @@ public Task DetachAsync()
         internal void Send(string method, object args = null)
             => _ = SendAsync(method, args, false);
 
-        internal bool HasPendingCallbacks() => _callbacks.Count != 0;
+        internal bool HasPendingCallbacks() => !_callbacks.IsEmpty;
 
         internal void OnMessage(ConnectionResponse obj)
         {

diff --git a/lib/PuppeteerSharp/Connection.cs b/lib/PuppeteerSharp/Connection.cs
@@ -190,7 +190,7 @@ internal async Task<CDPSession> CreateSessionAsync(TargetInfo targetInfo, bool i
             return await GetSessionAsync(sessionId).ConfigureAwait(false);
         }
 
-        internal bool HasPendingCallbacks() => _callbacks.Count != 0;
+        internal bool HasPendingCallbacks() => !_callbacks.IsEmpty;
 
         internal void Close(string closeReason)
         {

diff --git a/lib/PuppeteerSharp/DOMWorld.cs b/lib/PuppeteerSharp/DOMWorld.cs
@@ -48,7 +48,7 @@ public DOMWorld(CDPSession client, FrameManager frameManager, Frame frame, Timeo
             _logger = _client.Connection.LoggerFactory.CreateLogger<DOMWorld>();
         }
 
-        internal ICollection<WaitTask> WaitTasks { get; set; }
+        internal ConcurrentSet<WaitTask> WaitTasks { get; set; }
 
         internal Frame Frame { get; }
 
@@ -143,7 +143,7 @@ internal async Task<IElementHandle> AdoptHandleAsync(IElementHandle handle)
         internal void Detach()
         {
             _detached = true;
-            while (WaitTasks.Count > 0)
+            while (!WaitTasks.IsEmpty)
             {
                 WaitTasks.First().Terminate(new Exception("waitForFunction failed: frame got detached."));
             }

diff --git a/lib/PuppeteerSharp/Page.cs b/lib/PuppeteerSharp/Page.cs
@@ -986,7 +986,7 @@ async void ResponseEventListener(object sender, ResponseCreatedEventArgs e)
         /// <inheritdoc/>
         public async Task<FileChooser> WaitForFileChooserAsync(WaitForFileChooserOptions options = null)
         {
-            if (!_fileChooserInterceptors.Any())
+            if (_fileChooserInterceptors.IsEmpty)
             {
                 await Client.SendAsync("Page.setInterceptFileChooserDialog", new PageSetInterceptFileChooserDialog
                 {
@@ -1472,7 +1472,7 @@ private async void Client_MessageReceived(object sender, MessageEventArgs e)
 
         private async Task OnFileChooserAsync(PageFileChooserOpenedResponse e)
         {
-            if (_fileChooserInterceptors.Count == 0)
+            if (_fileChooserInterceptors.IsEmpty)
             {
                 try
                 {
@@ -1493,7 +1493,7 @@ private async Task OnFileChooserAsync(PageFileChooserOpenedResponse e)
             var world = context.World;
             var element = await world.AdoptBackendNodeAsync(e.BackendNodeId).ConfigureAwait(false);
             var fileChooser = new FileChooser(element, e);
-            while (_fileChooserInterceptors.Count > 0)
+            while (!_fileChooserInterceptors.IsEmpty)
             {
                 var key = _fileChooserInterceptors.FirstOrDefault().Key;