-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Firefox Support #1640
Conversation
# Conflicts: # lib/PuppeteerSharp.DevicesFetcher/Program.cs # lib/PuppeteerSharp.Tests/InputTests/PageWaitForFileChooserTests.cs # lib/PuppeteerSharp.Tests/Issues/Issue0616.cs # lib/PuppeteerSharp.Tests/Issues/Issue0648.cs # lib/PuppeteerSharp.Tests/Issues/Issue0716.cs # lib/PuppeteerSharp.Tests/Issues/Issue0764.cs # lib/PuppeteerSharp.Tests/PageTests/Events/CloseTests.cs # lib/PuppeteerSharp.Tests/PageTests/Events/PopupTests.cs # lib/PuppeteerSharp.Tests/PuppeteerTests/PuppeteerLaunchTests.cs # lib/PuppeteerSharp.Tests/TargetTests/TargetTests.cs # lib/PuppeteerSharp.Tests/TestConstants.cs # lib/PuppeteerSharp/BrowserFetcher.cs # lib/PuppeteerSharp/LaunchOptions.cs # lib/PuppeteerSharp/NetworkManager.cs
…peteer-sharp into v2.1.1/firefox-support
…peteer-sharp into v2.1.1/firefox-support
I'm not sure how far this work has come or if you want input, but when I try it out locally on Windows it fails with
after initializing with |
Hey @slashP what's the exception? |
Not sure how to extract more info from it at this point. |
We have lots of zombies
- framework: net48 | ||
ENQUEUE_ASYNC_MESSAGES: false | ||
- framework: netcoreapp2.2 | ||
ENQUEUE_ASYNC_MESSAGES: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kblok Why remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make much sense to test all the combinations with ENQUEUE_ASYNC_MESSAGES
.
Puppeteer works well in .NET Core without enqueuing messages. That was implemented for .NET Framework users.
closes #1472
closes #1494
closes #1617