Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Firefox Support #1640

Merged
merged 41 commits into from
Mar 18, 2021
Merged

Experimental Firefox Support #1640

merged 41 commits into from
Mar 18, 2021

Conversation

kblok
Copy link
Member

@kblok kblok commented Feb 27, 2021

closes #1472
closes #1494
closes #1617

kblok added 17 commits November 9, 2020 09:13
# Conflicts:
#	lib/PuppeteerSharp.DevicesFetcher/Program.cs
#	lib/PuppeteerSharp.Tests/InputTests/PageWaitForFileChooserTests.cs
#	lib/PuppeteerSharp.Tests/Issues/Issue0616.cs
#	lib/PuppeteerSharp.Tests/Issues/Issue0648.cs
#	lib/PuppeteerSharp.Tests/Issues/Issue0716.cs
#	lib/PuppeteerSharp.Tests/Issues/Issue0764.cs
#	lib/PuppeteerSharp.Tests/PageTests/Events/CloseTests.cs
#	lib/PuppeteerSharp.Tests/PageTests/Events/PopupTests.cs
#	lib/PuppeteerSharp.Tests/PuppeteerTests/PuppeteerLaunchTests.cs
#	lib/PuppeteerSharp.Tests/TargetTests/TargetTests.cs
#	lib/PuppeteerSharp.Tests/TestConstants.cs
#	lib/PuppeteerSharp/BrowserFetcher.cs
#	lib/PuppeteerSharp/LaunchOptions.cs
#	lib/PuppeteerSharp/NetworkManager.cs
@slashP
Copy link

slashP commented Mar 5, 2021

I'm not sure how far this work has come or if you want input, but when I try it out locally on Windows it fails with

   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at PuppeteerSharp.States.ChromiumStartingState.<StartCoreAsync>d__6.MoveNext() in C:\dev\priv\puppeteer-sharp\lib\PuppeteerSharp\States\ChromiumStartingState.cs:line 82

after initializing with Product.Firefox in BrowserFetcherOptions and LaunchOptions. The error occurs first, then the browser does in fact start. Looking forward to seeing this working!

@kblok
Copy link
Member Author

kblok commented Mar 5, 2021

Hey @slashP what's the exception?

@slashP
Copy link

slashP commented Mar 5, 2021

PuppeteerSharp.ProcessException: 'Failed to launch browser! on await p.StartCompletionSource.Task.ConfigureAwait(false); from the OnProcessExitedWhileStarting method it looks like. Process has start info:

StartInfo	FileName="C:\\blablabla\bin\\Debug\\net5.0\\.local-firefox\\Win64-87.0a1\\firefox\\firefox.exe", Arguments="--no-remote --foreground about:blank --remote-debugging-port=0 --profile \"C:\\Users\\blabla\\AppData\\Local\\Temp\\czwttcyf.iu3\"", WorkingDirectory=""

Not sure how to extract more info from it at this point.

@kblok kblok merged commit 6472015 into master Mar 18, 2021
@kblok kblok deleted the v2.1.1/firefox-support branch March 18, 2021 11:33
- framework: net48
ENQUEUE_ASYNC_MESSAGES: false
- framework: netcoreapp2.2
ENQUEUE_ASYNC_MESSAGES: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kblok Why remove these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make much sense to test all the combinations with ENQUEUE_ASYNC_MESSAGES.
Puppeteer works well in .NET Core without enqueuing messages. That was implemented for .NET Framework users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puppeteer-sharp downloads old version of chromium Test firefox in CI Set default Firefox prefs
3 participants