Automate nuget org push #2079
Automate nuget org push #2079
Conversation
doing stuff from https://github.com/dotnet/sourcelink and enabled determenistic build on github actions and appveyor
|
Is it possible that the tests are a bit flaky? I had a quick look into the failing test running on appveyor and is saw at least PuppeteerSharp.Tests.TargetTests.BrowserWaitForTargetTests.ShouldWaitForATarget failing some times running on github actions too. |
.github/workflows/dotnet.yml
Outdated
| @@ -48,3 +49,43 @@ jobs: | |||
| export DISPLAY=:1.5 | |||
| cd lib/PuppeteerSharp.Tests | |||
| dotnet test -f net6.0 -s test.runsettings -c Debug --logger "trx;LogFileName=TestResults.xml" | |||
|
|
|||
| deployRelease: | |||
| if: startsWith( github.ref, 'refs/heads/release-' ) | |||
There was a problem hiding this comment.
Does this mean the tags need to begin with release- or is this a Github convention?
We could just listen to git tags.
There was a problem hiding this comment.
Not sure. I used refs/heads/ always to filter branches and used marvinpinto/action-automatic-releases to add tags. I can look that up and report back later.
Are you using tags added by hand to mark releases?
There was a problem hiding this comment.
I use the Release feature from github that creates a tag.
There was a problem hiding this comment.
I think you would like to have something that is not filtered to any tag or branch and triggered by you without any automated trigger. Have I got it right? Then it would make sense to pull it out into a new workflow.
There was a problem hiding this comment.
Ideally. If we can get a new version when I hit "publish release' and a tag is created, that would be awesome.
|
Yes, tests can be quite flaky :( |
|
@stesee just to confirm. This is ready to go right? |
|
Found some more issues while testing - give the new workflow PushToIntNugetOrg a try 🤖. |
Updated api keys
There are two steps that I wont be able to prepare... btw. not able without authorization at nuget.org to change your package.